[makeotf] expects .glif file to be in a specific order

[frankrolf]

This is probably related to #701.
makeotf inexplicably stopped working for me, for an in-development UFO file.
I could isolate the bug to the element order in a .glif file.

This example will make makeotf fail:

<?xml version="1.0" encoding="UTF-8"?>
<glyph name="C" format="2">
	<unicode hex="0043"/>
	<advance width="663"/>
	<outline>
		<contour>
			<point x="649" y="54" type="curve"/>
			<point x="644" y="87"/>
			<point x="636" y="118"/>
			<point x="622" y="146" type="curve"/>
			<point x="558" y="118"/>
			<point x="508" y="106"/>
		</contour>
	</outline>
	<guideline x="713" y="389" angle="90" identifier="c2PHNxJalT"/>
</glyph>

$ makeotf -f GuidelineTest.ufo/
makeotf [Error] Could not find FontName (a.k.a. PostScript name) in FontDict of file '/Users/fgriessh/work/Chidori/UFO copy/GuidelineTest.ufo'

This modification makes it work:

<?xml version="1.0" encoding="UTF-8"?>
<glyph name="C" format="2">
	<unicode hex="0043"/>
	<advance width="663"/>
	<guideline x="713" y="389" angle="90" identifier="c2PHNxJalT"/>
	<outline>
		<contour>
			<point x="649" y="54" type="curve"/>
			<point x="644" y="87"/>
			<point x="636" y="118"/>
			<point x="622" y="146" type="curve"/>
			<point x="558" y="118"/>
			<point x="508" y="106"/>
		</contour>
	</outline>
</glyph>

$ makeotf -f GuidelineTest.ufo/
makeotfexe [NOTE] Adding glyph .notdef, SID 0.
Built development mode font 'GuidelineTest-Regular.otf'.

Note that the latter is not the order in which the UFOnormalizer sorts the XML structure – after normalizing, guidelines end up at the bottom of the tree.

Test UFO file attached.
GuidelineTest.ufo.zip

[miguelsousa]

This is a shortcoming in tx's UFO-reading code as well. Working on a fix.

[benkiel]

Thought: use fonttools.ufoLib to read UFOs in tx?

[miguelsousa]

We've discussed that already in #475

[benkiel]

Duh. Apologies.