Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[makeotf] Do not create zero-kB file when failing? #736

Closed
frankrolf opened this issue Feb 8, 2019 · 0 comments
Closed

[makeotf] Do not create zero-kB file when failing? #736

frankrolf opened this issue Feb 8, 2019 · 0 comments
Assignees
@miguelsousa
Labels
py-tools

Comments

@frankrolf
Copy link
Member

I am currently debugging a mark feature overflow. In the process, I encounter this message:

makeotfexe [FATAL] <SourceSerifProMaster-2> In feature 'mark' lookup 'MARK_BASE_above' mark to base positioning rules cause an offset overflow (0x10244) to a lookup subtable
makeotf [Error] Failed to build output font file 'SourceSerifProMaster-2.otf'.

As a result a zero-kB file 'SourceSerifProMaster-2.otf is created, which is unnecessary.
miguelsousa added a commit that referenced this issue Feb 9, 2019
@miguelsousa
[makeotf] Delete zero-size font on failure
a86aeff 
Fixes #736
@miguelsousa miguelsousa self-assigned this Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miguelsousa miguelsousa

Labels
py-tools
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frankrolf @miguelsousa