Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[makeotf] Duplicated warning for empty fontinfo fields #751

Closed
frankrolf opened this issue Mar 3, 2019 · 2 comments
Closed

[makeotf] Duplicated warning for empty fontinfo fields #751

frankrolf opened this issue Mar 3, 2019 · 2 comments
Assignees
@miguelsousa
Labels
py-tools

Comments

@frankrolf
Copy link
Member

When I just run makeotf on a very simple (attached) UFO which does not contain any copyright or trademark info, I get the following warning:

tx: --- font.ufo
tx: (ufr) Warning: Encountered empty <string> for fontinfo key copyright. Skipping
tx: (ufr) Warning: Encountered empty <string> for fontinfo key trademark. Skipping
tx: --- font.ufo
tx: (ufr) Warning: Encountered empty <string> for fontinfo key copyright. Skipping
tx: (ufr) Warning: Encountered empty <string> for fontinfo key trademark. Skipping
Built development mode font 'Exercise1-Regular.otf'.

I think it’s good to have the warning, however it doesn’t need to be duplicated.
font.ufo.zip
@miguelsousa
Copy link
Member

The second set might be something that fdkutils is doing, whereas the first set is tx printing straight to stderr.

Try running a simple tx command to see how many sets of messages you get.

@frankrolf
Copy link
Member Author

A single set only.

@miguelsousa miguelsousa changed the title [tx] Duplicated warning for empty fontinfo fields [makeotf] Duplicated warning for empty fontinfo fields Mar 4, 2019
@miguelsousa miguelsousa self-assigned this Mar 4, 2019
miguelsousa added a commit that referenced this issue Mar 4, 2019
@miguelsousa
[makeotf] Consume tx's stderr messages when fetching the font's PS name
c1b2036 
Fixes #751
miguelsousa added a commit that referenced this issue Mar 4, 2019
@miguelsousa
Test case for #751
6604b6d
miguelsousa added a commit that referenced this issue Mar 4, 2019
@miguelsousa
Test case for #751
3ce7447
@benkiel benkiel mentioned this issue Jan 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miguelsousa miguelsousa

Labels
py-tools
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frankrolf @miguelsousa