Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[makeinstancesufo] minor problems #753

Closed
frankrolf opened this issue Mar 4, 2019 · 4 comments
Closed

[makeinstancesufo] minor problems #753

frankrolf opened this issue Mar 4, 2019 · 4 comments
Assignees
Labels

Comments

@frankrolf
Copy link
Member

makeinstancesufo has a few problems when generating instances:

★ instances’ lib['public.glyphOrder'] is scrambled
★ instances lose all groups not related to kerning

In addition to that, I noticed that it is no longer possible to generate to the current path without ./ prefix:

this works:
<instance familyname="Test" filename="./Test-Result.ufo" stylename="Result">
this doesn’t work (but used to):
<instance familyname="Test" filename="Test-Result.ufo" stylename="Result">

@frankrolf
Copy link
Member Author

Test scenario attached.
The command run is makeinstancesufo -acnd Test.designspace
makeinstancesufo test.zip

@miguelsousa miguelsousa self-assigned this Mar 4, 2019
@miguelsousa
Copy link
Member

I'll investigate. My guess is that these are caused by ufoProcessor.

@miguelsousa
Copy link
Member

Fix for the filename problem: LettError/ufoProcessor#19

@miguelsousa
Copy link
Member

The groups problem depends on this patch: LettError/ufoProcessor#20
But you also need to add <groups copy="1"/> to the default master in the designspace file.

The lib['public.glyphOrder'] problem will go away once you add <lib copy="1"/> to the default master.

miguelsousa added a commit that referenced this issue Mar 7, 2019
miguelsousa added a commit that referenced this issue Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants