Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix makeotfexe setting of OS/2.ulCodePageRange bits #1042

Merged
merged 3 commits into from
Dec 3, 2019

Conversation

josh-hadley
Copy link
Collaborator

  • Fixes a bug in indexing into Unicode block definitions in map.c (a previous update had changed the ordering of the blocks, but the indices pointing to them were not updated, so tests for presence of Unicode blocks related to Code Page Ranges were failing, thus the bits not being set)
  • Adds tests to guard against future regressions of this nature
  • Updates version #s of makeotfexe, makeotf.py and OTF Library (HOT_VERSION)

closes #1040

cjchapman and others added 3 commits December 2, 2019 15:22
* updated generate_uniblock.py to output values for BOPOMOFO_INX, CJK_IDEO_INX, HANGUL_SYL_INX, HIRAGANA_INX, and KATAKANA_INX

* updated map.c to use new values for BOPOMOFO_INX, CJK_IDEO_INX, HANGUL_SYL_INX, HIRAGANA_INX, and KATAKANA_INX
- added `cidfont.ps` (Adobe Blank), plus 4 modified CMaps for Japanese, Simplified Chinese, Traditional Chinese, and Korean
- added expected OS/2 table TTX dumps
- added test to confirm that makeotfexe generates expected OS/2 tables for above
- update HOT_VERSION to 0x10070 ("1.0.112")
- update makeotfexe version to "2.5.65598"
- update makeotf.py version to "2.7.10 Dec 3 2019"
Copy link
Contributor

@readroberts readroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me!

@josh-hadley josh-hadley merged commit ee010d9 into develop Dec 3, 2019
@josh-hadley josh-hadley deleted the makeotfexe-fix-os2-code-page-ranges branch December 3, 2019 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

makeotf 2.7.8 and 2.7.9 produces probably incorrect Code Page Character Range value
3 participants