Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[autohint] [stemhist] redirect to psautohint/psstemhist #1077

Merged
merged 2 commits into from
Jan 9, 2020

Conversation

josh-hadley
Copy link
Collaborator

No description provided.

- updated autohint.py to simply call psautohint with supplied args
- updated autohint test data with psautohint test data (also modified ufo2-wd test case, which was overlooked in psautohint compatibility testing)
- removed stray fmtsh.py file from psstemhist expected output folder
- updated stemhist.py to simply call psstemhist with supplied args
- updated stemhist test data with psstemhist test data (NOTE: significant changes!)
- removed, as it is only used by autohint.py, which is on the way out
@lgtm-com
Copy link

lgtm-com bot commented Jan 9, 2020

This pull request fixes 33 alerts when merging 6c59020 into fb5b3d4 - view on LGTM.com

fixed alerts:

  • 10 for Unused local variable
  • 9 for Testing equality to None
  • 6 for Unused import
  • 3 for Variable defined multiple times
  • 1 for Except block handles 'BaseException'
  • 1 for Unreachable code
  • 1 for 'import *' may pollute namespace
  • 1 for Use of 'global' at module level
  • 1 for Nested loops with same variable

Copy link
Member

@miguelsousa miguelsousa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@josh-hadley josh-hadley merged commit de9138b into develop Jan 9, 2020
@josh-hadley josh-hadley deleted the jh-replace-autohint-stemhist branch January 9, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants