[ufotools] remove unused code #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed numerous methods and classes that are no longer used anywhere in the AFDKO anymore. Improves code coverage since the unused code was not being tested, either.
- remove psautohint.ufoFont.HashPointPen
|
This pull request fixes 2 alerts when merging e79c842 into bbedb0e - view on LGTM.com fixed alerts:
|
miguelsousa
previously approved these changes
Mar 4, 2020
python/afdko/ufotools.py
Outdated
| # the inital moveto to a lineto. | ||
| firstPointElement.set("type", "line") | ||
|
|
||
|
|
||
| bezToUFOPoint = { |
There was a problem hiding this comment.
bezToUFOPoint dict can be removed as well, I think.
There was a problem hiding this comment.
done (and more) in 058525a
- removed additional unused code and constants that @miguelsousa pointed out - updated module documentation to reflect the updated purpose of the module as an AFDKO-internal library.
|
This pull request fixes 2 alerts when merging 058525a into bbedb0e - view on LGTM.com fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed unused methods, imports, and classes from ufotools.py module which are no longer used since autohint has been deprecated. This has a side-effect of improving test code coverage.