Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spec] Replace invalid example in Feature File spec [skip ci] #1107

Merged
merged 1 commit into from
Mar 25, 2020
Merged

[spec] Replace invalid example in Feature File spec [skip ci] #1107

merged 1 commit into from
Mar 25, 2020

Conversation

josh-hadley
Copy link
Collaborator

Replaced incorrect sub s s by germandbls for latn/DEU with c_h & c_k for §4.h Example 2 (these are taken from Example 1 of that section for latn/DEU)

Closes #1106

@josh-hadley
[spec] Replace invalid example in Feature File spec [skip ci]
f14f8b3 
Replaced incorrect `sub s s by germandbls` for latn/DEU with `c_h` & `c_k` for §4.h Example 2 (these are taken from Example 1 of that section for latn/DEU)

Closes #1106
frankrolf
frankrolf approved these changes Mar 25, 2020
View reviewed changes
Copy link
Member

@frankrolf frankrolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Although c_h and c_k are archaic, at least they don’t produce grammatically-incorrect results.

@josh-hadley josh-hadley merged commit 8679e78 into develop Mar 25, 2020
@josh-hadley josh-hadley deleted the jh-spec-update branch March 25, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankrolf frankrolf frankrolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[spec] Invalid example in Feature File Specification
2 participants
@josh-hadley @frankrolf