Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[makeotf] avoid potential issue in recode.c #1109

Merged
merged 1 commit into from
Mar 26, 2020
Merged

[makeotf] avoid potential issue in recode.c #1109

merged 1 commit into from
Mar 26, 2020

Conversation

josh-hadley
Copy link
Collaborator

Closes #1108

@josh-hadley
[makeotf] avoid potential issue in recode.c
d87f72a 
- initialize `minsize` (int) to `INT_MAX` instead of `SHRT_MAX`
- increment HOT_VERSION to 1.0.113
blueshade7
blueshade7 approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@blueshade7 blueshade7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@josh-hadley josh-hadley merged commit 0d3790c into develop Mar 26, 2020
@josh-hadley josh-hadley deleted the jh-recode-minsize branch March 26, 2020 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blueshade7 blueshade7 blueshade7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[makeotf] bug in recode.c which may result in crash with certain fonts
2 participants
@josh-hadley @blueshade7