Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In otf2ttf conversion update LSB in hmtx to match xMin #1114

Merged
merged 1 commit into from
Apr 6, 2020
Merged

In otf2ttf conversion update LSB in hmtx to match xMin #1114

merged 1 commit into from
Apr 6, 2020

Conversation

punchcutter
Copy link
Contributor

No description provided.

josh-hadley
josh-hadley requested changes Apr 6, 2020
View reviewed changes
Copy link
Collaborator

@josh-hadley josh-hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test case (or update an existing one) for this?

@punchcutter punchcutter changed the base branch from master to develop April 6, 2020 22:19
josh-hadley
josh-hadley approved these changes Apr 6, 2020
View reviewed changes
Copy link
Collaborator

@josh-hadley josh-hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@punchcutter punchcutter merged commit 426b936 into develop Apr 6, 2020
@punchcutter punchcutter deleted the otf2ttf-fix branch April 6, 2020 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josh-hadley josh-hadley josh-hadley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@punchcutter @josh-hadley