Support multiple chained lookups per position #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@simoncozens Please rebase this after PR #1127 has been reviewed and merged. Thanks! @punchcutter Please wait until Simon's rebased this before reviewing. Thanks! |
punchcutter
reviewed
May 9, 2020
punchcutter
reviewed
May 9, 2020
punchcutter
reviewed
May 9, 2020
punchcutter
reviewed
May 9, 2020
punchcutter
reviewed
May 9, 2020
|
OK, that's all in. Waiting for Khaled's PR to drop then I'll rebase. |
|
Awesome, I've been wanting to get this in for a while. Thanks for getting it done. |
punchcutter
reviewed
May 10, 2020
There was a problem hiding this comment.
@simoncozens Looks good and the STAT PR is in so you can rebase. I would like to add examples to the spec, but we can also do that later because I'd really like to go over the whole thing and add/update all the examples.
simoncozens
force-pushed
the
multiple-lookups
branch
from
430db8a
to
2aaa702
Compare
|
Done, I think, assuming I haven't messed up the git-fu. |
simoncozens
added a commit
to fonttools/fonttools
that referenced
this pull request
May 12, 2020
This allows for more than one "lookup ..." chaining statements at each glyph position in a chaining contextual substitution or positioning rule: e.g.
sub a b c' lookup lookup1 lookup lookup2 d;
The corresponding change in the Adobe OpenType Feature File Specification (and implementation in makeotf) happened in adobe-type-tools/afdko#1132.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1119. This allows for e.g.
sub a' b lookup l1 lookup l2;I am not quite sure if it works for pos rules too, although that's probably a one-character fix in the grammar if not.andpos a' lookup l1 lookup l2;See also independent Python implementation in fonttools/fonttools#1905.