Initialize variables before use #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building an afdko package on the openSUSE build service many tests failed. After some investigation I compared the workflow in parallel debugging sessions inside the build service and a regular system (where they didn't fail). I noticed the reason of the failing is that afdko uses some variables that were not initialized so on systems where memory is automatically set to 0 they work fine, but this is not safe in general (and cannot be guaranteed), so it's better to initialize the variables.
josh-hadley
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building an afdko package on the openSUSE build service
many tests failed. After some investigation I compared the workflow
in parallel debugging sessions inside the build service and a
regular system (where they didn't fail). I noticed the reason
of the failing is that afdko uses some variables that were not
initialized so on systems where memory is automatically set to 0
they work fine, but this is not safe in general (and cannot
be guaranteed), so it's better to initialize the variables.