[makeotf] Drop old MM in OpenType support

[khaledhosny]

Fixes #995

[khaledhosny]

There is also code for reading MM from CFF fonts, but I’m not sure if I should remove it as well.

[khaledhosny]

There are some memory access issues I’m unable to track. I guess I should close the PR then, removing some unused and essentially harmless code is not worth the trouble.

[cjchapman]

Also: OpebType -> OpenType. 😉

[cjchapman]

@khaledhosny I think this PR is OK as is, so I'm going to go ahead and approve it, but I noticed some multi-master code that still remains, in case you want to clear these out as part of this PR:

• cffread.h
  • remove mm struct — this will likely uncover more than what I’ve listed below
• cffread.c
  • remove cff_MultipleMaster case from DICTRead()
• parse.c
  • remove saveForceBold()
  • remove saveMM()
• recode.c
  • in recodeAddNewGlyph(), remove these mm-related variables that are assigned values but not used:
    • metrics_gi
    • max_x
    • max_y
  • remove FillinMM_font_clampUDV()

[khaledhosny]

Yes, that is the MM reading code I was referring to in the commit message. I’ll work on it.

[cjchapman]

Sorry, I spaced out on your comment about the MM reading code in my excitement over the memory issues. 😉

Thanks.

[khaledhosny]

It seems that recodeAddNewGlyph() is used for the -adds option which adds glyphs from a MM font, so I guess we will have to keep it as long as this option is supported.

[josh-hadley]

It seems that recodeAddNewGlyph() is used for the -adds option which adds glyphs from a MM font, so I guess we will have to keep it as long as this option is supported.

I suspect -adds does not get used very much, if at all, these days. But I don't think we should just remove it right now. I think we should discuss a bit, and if removing it is warranted, I propose we deprecate it (with warnings when triggered), and target for removal at some later date. After that we can revisit removal of recodeAddNewGlyph() and any related code.

@khaledhosny does that sound reasonable? Please let us know if you plan to make any more updates on this PR; if not, I think we ought to wrap it up and get it merged soon. I will open up an issue on the removal of -adds to give the community an opportunity to discuss.

[khaledhosny]

It seems that recodeAddNewGlyph() is used for the -adds option which adds glyphs from a MM font, so I guess we will have to keep it as long as this option is supported.

I suspect -adds does not get used very much, if at all, these days. But I don't think we should just remove it right now. I think we should discuss a bit, and if removing it is warranted, I propose we deprecate it (with warnings when triggered), and target for removal at some later date. After that we can revisit removal of recodeAddNewGlyph() and any related code.

Makes sense.

@khaledhosny does that sound reasonable? Please let us know if you plan to make any more updates on this PR; if not, I think we ought to wrap it up and get it merged soon.

No more changes from me.