Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tx] don't write FontMatrix in CFF2 FontDict #1165

Merged
merged 2 commits into from
Jun 12, 2020
Merged

Conversation

josh-hadley
Copy link
Collaborator

@josh-hadley josh-hadley commented Jun 12, 2020

  • update cffwrite_dict.c so that it does not write FontMatrix in cfwDictFillFont in the CFF2 case
  • added tests for above (CFF and CFF2 output)
  • updated cffwrite version to 1.0.56

- update cffwrite_dict.c so that it does not write FontMatrix in cfwDictFillTop in the CFF2 case
- added tests for above (CFF and CFF2 output)
- updated cffwrite version to 1.0.56
Copy link
Contributor

@cjchapman cjchapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use tx -dump to dump the output CFF/CFF2 in human-readable form and then diff that in the test code (rather than diffing the binary output).

- added text-based expected output; removed binary
- modify test code to do 2-step output (binary, then text dump of generated binary)
@anthrotype
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants