[checkoutlinesufo, ufotools] improve overlap removal, error messages #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- set `ctr_starts` dict based on contours of `fixed_glyph` to avoid IndexError for some cases
- set threshold to 0.5 - abandon attempt to re-set `smooth="yes"` - update checkoutlines and makeinstances tests that were affected by smooth logic
- use ufoFormatVersionTuple - improve messaging for failed assertion - improve messaging for KeyError
As a result of other changes, this class is not used anywhere.
|
@frankrolf @punchcutter I would like to have you both review this if possible -- this addresses several issues on #1145 that Frank has been following. I have another related branch that will also apply to that effort. |
punchcutter
reviewed
Jun 15, 2020
frankrolf
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thresholdAttrGlyphmethod: don't try to "fix" smooth points, use threshold of 0.5 N.B. this change causes changes to test data w/r/t smoothed pointsufoVersionFormatTupleconsistently throughout module