[makeotf] Check for PostScript name in FontMenuNameDB file

[miguelsousa]

Fixes #1171

[frankrolf]

This did not work as expected. I did the following:

# install and activate venv
python -m venv fmndb_update
source fmndb_update/bin/activate

# install and verify branch
pip install git+https://github.com/adobe-type-tools/afdko.git@ms-fmndb-bug1171
which makeotf  # -> /Users/fgriessh/Desktop/fmndb_update/bin/makeotf

# cd to directory where a UFO file is
makeotf -f Exercise3_0.ufo

# output
makeotf [Warning] Could not find default features file. Font will be built without any layout features.
makeotfexe [WARNING] not in FontMenuNameDB [Exercise3-Master0]
makeotfexe [FATAL] <Exercise3-Master0> I can't find a Family name for this font !
Error executing command 'makeotfexe -f /var/folders/7z/vl3dc3kd07bfz1q_5ybyk5wm0000gn/T/tmpa8w09wt5 -o /Users/fgriessh/work/fmndb/Masters/Exercise3-Master0.otf -mf /Users/fgriessh/work/fmndb/FontMenuNameDB -shw'
makeotf [Error] Failed to build output font file '/Users/fgriessh/work/fmndb/Masters/Exercise3-Master0.otf'.

That is not the expected behavior, is it? Can I install the PR differently?

[frankrolf]

Same result when using a pointer to the commit instead:
pip install git+https://github.com/adobe-type-tools/afdko.git@797a6d757381aae2a0be7fc17035b9ae899f1fce

[frankrolf]

Just for being thorough, I also tried creating the virtual environment differently – using virtualenv. Same overall result.

I am curious though – the version number fix does not seem to make it through, when doing pip list, the afdko lists as afdko 2.7.1.dev1226+g797a6d75 instead of 2.8.0. Expected?

[miguelsousa]

The steps you did should have worked. Not sure why they don't.

[punchcutter]

Worked for me, but I ran into something else. I had the name commented out in the FontMenuNameDB so this still found it, but couldn't parse it because it was commented out.

[miguelsousa]

I had the name commented out

Good catch. I'll update the PR to account for that case.

[punchcutter]

LGTM

[frankrolf]

Confirmed working now – just installed the commit without Virtual Env. Thanks!