[autohint, stemhist, requirements, tests, setup] updates related to psautohint #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
josh-hadley
commented
Jun 25, 2020
josh-hadley
commented
- update requirements to use latest psautohint
- remove autohint.py and related code: closes Remove autohint tool #826
- remove stemhist.py and related code: closes Remove stemhist tool #827
- update AFDKO-Overview.md description of psautohint/psstemhist tools to indicate that they are in a separate repo
- update convertfonttocid.py documentation (autohint -> psautohint)
- update description of autohint/psautohint and stemhist/psstemhist
- remove autohint.py and stemhist.py stubs (which simply called psautohint/psstemhits)
- change instances of 'autohint' to 'psautohint'
- remove autohint and stemhist from console scripts section
miguelsousa
requested changes
Jun 25, 2020
`--doc-fddict` instead of legacy autohint `-hfd` flag
miguelsousa
approved these changes
Jun 25, 2020
|
Looking at https://codecov.io/gh/adobe-type-tools/afdko/pull/1175/changes it seems that we lost a bit of coverage on the C side. I wonder which removed test made those lines in |
Yeah, I think it will probably be easier to add new test code for one of the various C tools where the cffwrite code is used than to try to track down the specific test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.