Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makeotfexe STAT/name table fixes #1179

Merged
merged 8 commits into from
Jul 9, 2020
Merged

makeotfexe STAT/name table fixes #1179

merged 8 commits into from
Jul 9, 2020

Conversation

punchcutter
Copy link
Contributor

@punchcutter punchcutter commented Jul 5, 2020

Add [STAT] to STAT table messages
Update STAT handling to write version 1.2 table only if there are Format 4 Axis value tables
Warn if unregistered axis tags are not uppercase
Warn if Format 2 default value is not in min-max range
Fail if DesignAxis tag has already been defined
Fail if Axis Value Table of the same format has already been defined with the same values

Add [name] to name table messages
Warn when overwriting existing nameid
Fail if GSUB or STAT are defined before name table and name table sets nameids above 255. Fixes #1178

Docs:
Clarify use of Unicode values in column 3 of GlyphOrderAndAliasDB. Fixes #1177

Update STAT handling to write version 1.2 table only if there are Format 4 Axis value tables
Warn if unregistered axis tags are not uppercase
Warn if Format 2 default value is not in min-max range
Fail if DesignAxis tag has already been defined
Fail if Axis Value Table of the same format has already been defined with the same values

Add `[name]` to name table messages
Warn when overwriting existing nameid
Fail if GSUB or STAT are defined before name table and name table sets nameids above 255: #1178

Docs:
Clarify use of Unicode values in column 3 of GlyphOrderAndAliasDB #1177
Copy link
Collaborator

@josh-hadley josh-hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 LGTM

@punchcutter punchcutter merged commit 3fb4941 into develop Jul 9, 2020
@punchcutter punchcutter deleted the zqs-stat-fixes branch July 9, 2020 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants