Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tx] improve robustness #1182

Merged
merged 2 commits into from
Jul 13, 2020
Merged

[tx] improve robustness #1182

merged 2 commits into from
Jul 13, 2020

Conversation

josh-hadley
Copy link
Collaborator

Description

Improve robustness in tx (and related components):

  • limit TTC table count to avoid massive memory allocation with malformed TTC
  • fix type and limit CFF[2] subr INDEX count to avoid integer overflow with malformed raw CFF2 file
  • reject raw CFF and CFF2 with incorrect header size
  • fix bug in checking instance name length (this also affected some tx test cases which were also updated)
  • updated applicable version numbers in components

- limit TTC table count to avoid massive memory allocation with malformed TTC
- fix type and limit CFF[2] subr INDEX count to avoid integer overflow with malformed raw CFF2 file
- reject raw CFF and CFF2 with incorrect header size
- fix bug in checking instance name length (this also affected some tx test cases which were also updated)
- updated applicable version numbers in components
- fix whitespace/end_of_line linter error
Copy link
Contributor

@cjchapman cjchapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@josh-hadley josh-hadley merged commit 9f0a4c2 into develop Jul 13, 2020
@josh-hadley josh-hadley deleted the jh-improve-robustness-2 branch July 13, 2020 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants