New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[makeotfexe] fix stack-buffer-overflow and heap-use-after-free #1183

Merged

cjchapman merged 2 commits into develop from cjc-fix-makeotfexe-mem-issues

Jul 14, 2020

Contributor

cjchapman commented Jul 14, 2020

This PR fixes two issues found by running makeotfexe_test.py with AddressSanitizer (ASAN):

heap-use-after-free in recode.c
stack-buffer-overflow in featgram.c

cjchapman added 2 commits

July 13, 2020 18:38


          [makeotfexe] fix heap-use-after-free in recode.c

fd6ba15


          [makeotfexe] fix stack-buffer-overflow in featgram.c

3d5b1a6

(also removed a superfluous pair of parentheses from some related code)

cjchapman requested a review from josh-hadley

July 14, 2020 02:31

josh-hadley approved these changes

View reviewed changes

Collaborator

josh-hadley left a comment

👍

cjchapman merged commit f908188 into develop

cjchapman deleted the cjc-fix-makeotfexe-mem-issues branch

July 14, 2020 16:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet