Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mergefonts] fix stack-buffer-overflow #1185

Merged
merged 1 commit into from
Jul 14, 2020
Merged

[mergefonts] fix stack-buffer-overflow #1185

merged 1 commit into from
Jul 14, 2020

Conversation

cjchapman
Copy link
Contributor

This PR fixes a stack-buffer-overflow in mergeFonts.c found by running mergefonts_test.py with AddressSanitizer (ASAN).

josh-hadley
josh-hadley approved these changes Jul 14, 2020
View reviewed changes
Copy link
Collaborator

@josh-hadley josh-hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cjchapman cjchapman merged commit 2e2d7fd into develop Jul 14, 2020
@cjchapman cjchapman deleted the cjc-mergefonts-fix-stack-buffer-overflow branch July 14, 2020 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josh-hadley josh-hadley josh-hadley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjchapman @josh-hadley