[makeotfexe] support OS/2.sFamilyClass in feature files #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add support to parse "FamilyClass" key of OS/2 tables in .fea files - update relevant version #s
cjchapman
suggested changes
Jul 21, 2020
| @@ -345,7 +346,7 @@ int OS_2Fill(hotCtx g) { | |||
| h->tbl.yStrikeoutSize = font->win.StrikeOutSize; | |||
| h->tbl.yStrikeoutPosition = font->win.StrikeOutPosition; | |||
|
|
|||
| h->tbl.sFamilyClass = CLASS_NONE; /* No classification */ | |||
| // h->tbl.sFamilyClass = CLASS_NONE; /* No classification */ | |||
There was a problem hiding this comment.
Please remove this commented-out code.
There was a problem hiding this comment.
d'oh! Thanks for catching this. Fixed in a41e3f9
per review in #1192
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update .fea parsing to accept token
FamilyClassfor OS/2 table definitions (sets theOS/2.sFamilyClassfield). Syntax is:FamilyClass <number>(inside of atable OS/2 { ... } OS/2block).<number>can be any decimal, hexadecimal, or octal number from 0 - 65535.Related: updated a number of OS/2 table field definitions to use
uint16_tandint16_t(intsead ofunsigned shortandshort) as part of an overall effort to use explicit bit lengths in OpenType tables.Added/updated tests, documentation, and updated version #s in relevant modules.
Closes #1191