Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dupe checking for STAT Format 4 axis values. #1195

Merged
merged 3 commits into from
Jul 28, 2020
Merged

Fix dupe checking for STAT Format 4 axis values. #1195

merged 3 commits into from
Jul 28, 2020

Conversation

punchcutter
Copy link
Contributor

Add Format 2 check for min > max.

josh-hadley
josh-hadley previously approved these changes Jul 23, 2020
View reviewed changes
Copy link
Collaborator

@josh-hadley josh-hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice improvements for STAT!

josh-hadley
josh-hadley approved these changes Jul 27, 2020
View reviewed changes
Copy link
Collaborator

@josh-hadley josh-hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@punchcutter punchcutter merged commit 5bf50b4 into develop Jul 28, 2020
@punchcutter punchcutter deleted the zqs-stat-format4 branch July 28, 2020 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josh-hadley josh-hadley josh-hadley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@punchcutter @josh-hadley