Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[makeotf] Allow anonymous glyphclass in LookupFlags #1206

Merged
merged 1 commit into from
Aug 25, 2020

Conversation

khaledhosny
Copy link
Collaborator

Description

Almost everywhere else when a glyph class name is accepted, anonymous glyph classes are also accepted. This is rather inconsistent and inconvenient

Checklist:

  • I have followed the Contribution Guidelines
  • I have added test code and data to prove that my code functions correctly
  • I have verified that new and existing tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@cjchapman
Copy link
Contributor

Looks like Travis passed, but never got back to GitHub about it:
https://travis-ci.org/github/adobe-type-tools/afdko/builds/715929569

@khaledhosny
Copy link
Collaborator Author

Looks like Travis passed, but never got back to GitHub about it:
https://travis-ci.org/github/adobe-type-tools/afdko/builds/715929569

Something is broken with Travis indeed, I force pushed to re-trigger the build but the same happened again. Build https://travis-ci.org/github/adobe-type-tools/afdko/builds/716378446 passes but it does not report it here.

@cjchapman
Copy link
Contributor

@khaledhosny Yes, Travis is definitely broken. We're seeing the same problem in other PRs. Josh is working on using GitHub Actions instead of Travis CI so that we can drop Travis.

Copy link
Contributor

@punchcutter punchcutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4d-8 and 4d-10 are the exact same. Was one meant to do MarkAttachmentType and the other UseMarkFilteringSet?

@khaledhosny
Copy link
Collaborator Author

4d-8 and 4d-10 are the exact same. Was one meant to do MarkAttachmentType and the other UseMarkFilteringSet?

Yes, fixed.

Almost everywhere else when a glyph class name is accepted, anonymous
glyph classes are also accepted. This is rather inconsistent and
inconvenient
Copy link
Contributor

@punchcutter punchcutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@punchcutter punchcutter merged commit b9220cb into develop Aug 25, 2020
@punchcutter punchcutter deleted the makeotf-lookupflag-anonclass branch August 25, 2020 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants