-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[makeotf] Allow anonymous glyphclass in LookupFlags #1206
Conversation
Looks like Travis passed, but never got back to GitHub about it: |
ae7cb87
to
dd80a8c
Compare
Something is broken with Travis indeed, I force pushed to re-trigger the build but the same happened again. Build https://travis-ci.org/github/adobe-type-tools/afdko/builds/716378446 passes but it does not report it here. |
@khaledhosny Yes, Travis is definitely broken. We're seeing the same problem in other PRs. Josh is working on using GitHub Actions instead of Travis CI so that we can drop Travis. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4d-8 and 4d-10 are the exact same. Was one meant to do MarkAttachmentType and the other UseMarkFilteringSet?
Yes, fixed. |
Almost everywhere else when a glyph class name is accepted, anonymous glyph classes are also accepted. This is rather inconsistent and inconvenient
53b1962
to
60a3bc8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Almost everywhere else when a glyph class name is accepted, anonymous glyph classes are also accepted. This is rather inconsistent and inconvenient
Checklist: