Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

agd: support five-digit code points #1208

Merged
merged 2 commits into from
Aug 22, 2020
Merged

agd: support five-digit code points #1208

merged 2 commits into from
Aug 22, 2020

Conversation

frankrolf
Copy link
Member

Description

bug fix to support 5-digit code points in tools relying on the agd.py module
resolves #1207

Checklist:

  • I have followed the Contribution Guidelines
  • I have added test code and data to prove that my code functions correctly
  • I have verified that new and existing tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

I would love to check all the boxes here, but don’t know where to start.
If necessary for this fix I’d appreciate being walked through. Thanks!

miguelsousa
miguelsousa reviewed Aug 12, 2020
View reviewed changes
python/afdko/agd.py Outdated Show resolved Hide resolved
miguelsousa
miguelsousa approved these changes Aug 13, 2020
View reviewed changes
Copy link
Member

@miguelsousa miguelsousa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@josh-hadley josh-hadley merged commit 4cdad52 into develop Aug 22, 2020
@josh-hadley josh-hadley deleted the agd-five-digit-code-points branch August 31, 2020 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelsousa miguelsousa miguelsousa approved these changes

@josh-hadley josh-hadley Awaiting requested review from josh-hadley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[comparefamily] [agd] trouble with five-digit code points
3 participants
@frankrolf @miguelsousa @josh-hadley