[pdfwrite] fix circle-drawing bug #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix bug in `drawCircle` as reported in #1218 - Add test case and data for `tx` using `-pdf -1` option to improve test coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A one-character change to
pdfwrite.cthat fixes an ancient bug discovered by @bcirc. Thanks to @frankrolf for generating a test font that demonstrates the bug (and is included in the updated test suite). The added test should also increase coverage ofpdfwrite.ca tiny bit.Closes #1218
Checklist:
I have commented my code, particularly in hard-to-understand areas(n/a)I have made corresponding changes to the documentation(n/a)