Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[checkoutlinesufo] fix nested loop variable #1231

Merged
merged 1 commit into from
Oct 5, 2020

Conversation

cjchapman
Copy link
Contributor

@cjchapman cjchapman commented Oct 2, 2020

This is a fix for the following issue identified by LGTM:

Nested for statement uses loop variable 'point' of enclosing for statement.

(I created this PR mainly to check if our LGTM configuration is still working now that GitHub's officially released "code scanning".)

@lgtm-com
Copy link

lgtm-com bot commented Oct 2, 2020

This pull request fixes 1 alert when merging ecf5429 into b1129a8 - view on LGTM.com

fixed alerts:

  • 1 for Nested loops with same variable

This is a fix for the following issue identified by LGTM:
Nested for statement uses loop variable 'point' of enclosing for statement.
@cjchapman cjchapman force-pushed the cjc_checkoutlinesufo_fix_nested_loop branch from ecf5429 to 1cf389c Compare October 2, 2020 21:31
@cjchapman
Copy link
Contributor Author

So this ended up being more informative than I expected, in that it:

@lgtm-com
Copy link

lgtm-com bot commented Oct 2, 2020

This pull request fixes 1 alert when merging 1cf389c into 2c36ad1 - view on LGTM.com

fixed alerts:

  • 1 for Nested loops with same variable

@josh-hadley josh-hadley merged commit edc7c4f into develop Oct 5, 2020
@josh-hadley josh-hadley deleted the cjc_checkoutlinesufo_fix_nested_loop branch October 5, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants