Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo by adding missing "font" #1236

Merged
merged 1 commit into from
Oct 12, 2020
Merged

Fix typo by adding missing "font" #1236

merged 1 commit into from
Oct 12, 2020

Conversation

drj11
Copy link
Contributor

@drj11 drj11 commented Oct 12, 2020

[skip ci]

The word "font" is missing in the description.

alerque
alerque previously approved these changes Oct 12, 2020
View reviewed changes
@cjchapman
Copy link
Contributor

@drj11 Please make your changes on the develop branch, not the master branch. The tests that are failing have been fixed on develop.

@drj11 drj11 changed the base branch from master to develop October 12, 2020 15:37
@drj11 drj11 dismissed alerque’s stale review October 12, 2020 15:37

The base branch was changed.

@drj11
Copy link
Contributor Author

drj11 commented Oct 12, 2020

I have rebased and moved the base branch, but unfortunately that has invalidated @alerque 's review.

@lgtm-com
Copy link

lgtm-com bot commented Oct 12, 2020

This pull request fixes 1 alert when merging d5b98bb into 6b810de - view on LGTM.com

fixed alerts:

  • 1 for Nested loops with same variable

cjchapman
cjchapman approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@cjchapman cjchapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cjchapman cjchapman merged commit bad960f into adobe-type-tools:develop Oct 12, 2020
@drj11 drj11 deleted the patch-1 branch October 12, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjchapman cjchapman cjchapman approved these changes

@alerque alerque alerque left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drj11 @cjchapman @alerque