Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[checkoutlinesufo] implement -o (output file) option #1244

Merged
merged 3 commits into from
Nov 10, 2020
Merged

[checkoutlinesufo] implement -o (output file) option #1244

merged 3 commits into from
Nov 10, 2020

Conversation

josh-hadley
Copy link
Collaborator

Description

  • updated checkoutlinesufo to accept -o/--output-file option, a path specifying an output file. When this option is specified, the input file will first be copied to the specified output file path, and successive operations will occur on that path.
  • added test case (uses existing input/expected data)

closes #1242

Checklist:

  • I have followed the Contribution Guidelines
  • I have added test code and data to prove that my code functions correctly
  • I have verified that new and existing tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@josh-hadley
[checkoutlinesufo] implement -o (output file) option
7c71c16 
- updated checkoutlinesufo to accept -o/--output-file option, a path specifying an output file. When this option is specified, the input file will first be copied to the specified output file path, and successive operations will occur on that path.
- added test case (uses existing input/expected data)
@lgtm-com
Copy link

lgtm-com bot commented Oct 24, 2020

This pull request introduces 1 alert when merging 7c71c16 into d90bda3 - view on LGTM.com

new alerts:

  • 1 for Module is imported with 'import' and 'import from'

cjchapman
cjchapman previously approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@cjchapman cjchapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@miguelsousa
Copy link
Member

@josh-hadley should the version number be bumped?

@josh-hadley
Update checkoutlinesufo.py
49b02a8 
- bump version to 2.4.5
@josh-hadley
Copy link
Collaborator Author

@josh-hadley should the version number be bumped?

Yes 😜
Just updated in 49b02a8

@josh-hadley josh-hadley merged commit 9adff30 into develop Nov 10, 2020
@josh-hadley josh-hadley deleted the jh-checkoutlinesufo-output branch November 10, 2020 23:58
miguelsousa
miguelsousa approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@miguelsousa miguelsousa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelsousa miguelsousa miguelsousa approved these changes

@cjchapman cjchapman cjchapman left review comments

@punchcutter punchcutter Awaiting requested review from punchcutter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[checkoutlinesufo] needs a -o (output file) option
3 participants
@josh-hadley @miguelsousa @cjchapman