Allow deleting glyphs #1251
Merged
Allow deleting glyphs #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh-hadley
requested changes
Feb 1, 2021
There was a problem hiding this comment.
@simoncozens thanks for this. This looks good to me, but I'd like to have you rebase & make any adjustments needed to get tests passing before we get it merged, if you don't mind.
josh-hadley
approved these changes
Feb 2, 2021
There was a problem hiding this comment.
Thanks again @simoncozens , looks good and will get this merged.
Looks like we need to iron out some issues with GitHub Actions running tests on forks. We've made a lot of updates to that whole thing since this PR was started/in Draft mode 3 months ago but there are still some details to work out.
ctrlcctrlv
added a commit
to ctrlcctrlv/fontforge
that referenced
this pull request
Feb 6, 2021
ctrlcctrlv
added a commit
to ctrlcctrlv/fontforge
that referenced
this pull request
Feb 6, 2021
ctrlcctrlv
added a commit
to ctrlcctrlv/fontforge
that referenced
this pull request
Feb 6, 2021
ctrlcctrlv
added a commit
to ctrlcctrlv/fontforge
that referenced
this pull request
Feb 6, 2021
ctrlcctrlv
added a commit
to fontforge/fontforge
that referenced
this pull request
Feb 10, 2021
Omnikron13
pushed a commit
to Omnikron13/fontforge
that referenced
this pull request
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #1234