Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Updates #1254

Merged
merged 5 commits into from
Nov 10, 2020
Merged

CI Updates #1254

merged 5 commits into from
Nov 10, 2020

Conversation

josh-hadley
Copy link
Collaborator

@josh-hadley josh-hadley commented Nov 10, 2020 •
edited
Loading

Description

Several major and minor updates relating to CI/automation:

  • set the GitHub Actions "build wheels" workflow to publish wheels on tag pushes (not part of this PR but related: disabled Travis CI and AppVeyor builds which did this previously)
  • added a scheduled (cron) run of the AFDKO Test Suite GitHub Actions workflow
  • updated AFDKO Test Suite GitHub Action to use MSBuild v1.0.2 to avoid use of a deprecated action
  • added workflow_dispatch event to all GitHub Actions workflows
  • fixed an issue in makeotf sources that caused a failure in Azure Pipelines Mac build
  • updated "CI Matrix" wiki page (not part of this PR but related)

Checklist:

  • I have followed the Contribution Guidelines
  • I have added test code and data to prove that my code functions correctly
  • I have verified that new and existing tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@josh-hadley
[ci] Update workflows [skip ci]
4ed1cf6 
- add `workflow_dispatch` event to all workflows (enable manual trigger from GitHub UI)
- add Python 3.9 to matrix in testpythonpackage.yml
- use `microsoft/setup-msbuild@v1.0.2` to avoid deprecation warning
@josh-hadley
[makeotf] add missing include
fce1914 
- Somehow `<math.h>` was not previously `#include`d, so added it to `featgram.g` to ensure it ends up in generated files. Fixes a failure in Azure CI mac build.
- Updated all relevant `makeotf` versions (`HOT_VERSION`, `makeotfexe` version, `makeotf.py` version)
@josh-hadley
Update testpythonpackage.yml
6a5c0e0 
Revert use of Python 3.9 in test -- blocked by #1253
@josh-hadley
Update run_cvg.yml
37a54e2 
- change workflow name to "C and Python coverage"
- change job name to "coverage"
@josh-hadley
Update build_wheels.yml
2dd51bf 
Switch deployment to real PyPI instead of Test.
miguelsousa
miguelsousa approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@miguelsousa miguelsousa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cjchapman
cjchapman approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@cjchapman cjchapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@josh-hadley josh-hadley merged commit 296d37a into develop Nov 10, 2020
@josh-hadley josh-hadley deleted the jh-ci-updates branch November 10, 2020 23:43
@josh-hadley josh-hadley mentioned this pull request Feb 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelsousa miguelsousa miguelsousa approved these changes

@cjchapman cjchapman cjchapman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josh-hadley @miguelsousa @cjchapman