Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[makeotfexe] Allow negative internal leading #1279

Merged
merged 3 commits into from
Jan 20, 2021
Merged

[makeotfexe] Allow negative internal leading #1279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca6f5ba
[makeotfexe] Allow negative internal leading
kaydeearts Jan 14, 2021
b710614
[makeotfexe] Adding test case for negative internal leading
kaydeearts Jan 13, 2021
3d47d94
[makeotfexe_test.py] Fix flake8 issues
kaydeearts Jan 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions c/makeotf/makeotf_lib/source/hotconv/hot.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,9 +715,8 @@ static void prepWinData(hotCtx g) {
}
intLeading = font->win.ascent + font->win.descent - font->unitsPerEm;
if (intLeading < 0) {
/* Avoid negative internal leading */
font->win.ascent -= intLeading;
intLeading = 0;
/* Warn about negative internal leading */
hotMsg(g, hotWARNING, "Negative internal leading: win.ascent + win.descent < unitsPerEm");
}

/* Set typo ascender/descender/linegap */
Expand Down
2 changes: 1 addition & 1 deletion tests/buildmasterotfs_data/expected_output/master0.ttx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
<sTypoAscender value="483"/>
<sTypoDescender value="-517"/>
<sTypoLineGap value="200"/>
<usWinAscent value="987"/>
<usWinAscent value="483"/>
<usWinDescent value="13"/>
<ulCodePageRange1 value="00000000 00000000 00000000 00000001"/>
<ulCodePageRange2 value="00000000 00000000 00000000 00000000"/>
Expand Down
2 changes: 1 addition & 1 deletion tests/buildmasterotfs_data/expected_output/master1.ttx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
<sTypoAscender value="503"/>
<sTypoDescender value="-497"/>
<sTypoLineGap value="200"/>
<usWinAscent value="984"/>
<usWinAscent value="503"/>
<usWinDescent value="16"/>
<ulCodePageRange1 value="00000000 00000000 00000000 00000001"/>
<ulCodePageRange2 value="00000000 00000000 00000000 00000000"/>
Expand Down
2 changes: 1 addition & 1 deletion tests/makeotf_data/expected_output/bug497/opts-bit7n-bit8n-bit9n.ttx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
<sTypoAscender value="660"/>
<sTypoDescender value="-340"/>
<sTypoLineGap value="200"/>
<usWinAscent value="988"/>
<usWinAscent value="660"/>
<usWinDescent value="12"/>
<ulCodePageRange1 value="00000000 00000000 00000000 00000001"/>
<ulCodePageRange2 value="00000000 00000000 00000000 00000000"/>
Expand Down
2 changes: 1 addition & 1 deletion tests/makeotf_data/expected_output/bug497/opts-bit7y-bit8n-bit7n-bit8y.ttx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
<sTypoAscender value="660"/>
<sTypoDescender value="-340"/>
<sTypoLineGap value="200"/>
<usWinAscent value="988"/>
<usWinAscent value="660"/>
<usWinDescent value="12"/>
<ulCodePageRange1 value="00000000 00000000 00000000 00000001"/>
<ulCodePageRange2 value="00000000 00000000 00000000 00000000"/>
Expand Down
2 changes: 1 addition & 1 deletion tests/makeotf_data/expected_output/bug497/opts-bit7y-bit8n-bit9n.ttx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
<sTypoAscender value="660"/>
<sTypoDescender value="-340"/>
<sTypoLineGap value="200"/>
<usWinAscent value="988"/>
<usWinAscent value="660"/>
<usWinDescent value="12"/>
<ulCodePageRange1 value="00000000 00000000 00000000 00000001"/>
<ulCodePageRange2 value="00000000 00000000 00000000 00000000"/>
Expand Down
2 changes: 1 addition & 1 deletion tests/makeotf_data/expected_output/bug497/opts-bit7y-bit8y-bit9y.ttx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
<sTypoAscender value="660"/>
<sTypoDescender value="-340"/>
<sTypoLineGap value="200"/>
<usWinAscent value="988"/>
<usWinAscent value="660"/>
<usWinDescent value="12"/>
<ulCodePageRange1 value="00000000 00000000 00000000 00000001"/>
<ulCodePageRange2 value="00000000 00000000 00000000 00000000"/>
Expand Down
2 changes: 1 addition & 1 deletion tests/makeotf_data/expected_output/bug497/opts-ga.ttx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
<sTypoAscender value="660"/>
<sTypoDescender value="-340"/>
<sTypoLineGap value="200"/>
<usWinAscent value="988"/>
<usWinAscent value="660"/>
<usWinDescent value="12"/>
<ulCodePageRange1 value="00000000 00000000 00000000 00000001"/>
<ulCodePageRange2 value="00000000 00000000 00000000 00000000"/>
Expand Down
2 changes: 1 addition & 1 deletion tests/makeotf_data/expected_output/bug497/opts-gf-ga-nga.ttx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
<sTypoAscender value="660"/>
<sTypoDescender value="-340"/>
<sTypoLineGap value="200"/>
<usWinAscent value="988"/>
<usWinAscent value="660"/>
<usWinDescent value="12"/>
<ulCodePageRange1 value="00000000 00000000 00000000 00000001"/>
<ulCodePageRange2 value="00000000 00000000 00000000 00000000"/>
Expand Down
2 changes: 1 addition & 1 deletion tests/makeotf_data/expected_output/bug497/opts-gf-ga.ttx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
<sTypoAscender value="660"/>
<sTypoDescender value="-340"/>
<sTypoLineGap value="200"/>
<usWinAscent value="988"/>
<usWinAscent value="660"/>
<usWinDescent value="12"/>
<ulCodePageRange1 value="00000000 00000000 00000000 00000001"/>
<ulCodePageRange2 value="00000000 00000000 00000000 00000000"/>
Expand Down
2 changes: 1 addition & 1 deletion tests/makeotf_data/expected_output/bug497/opts-gf-nga-ga.ttx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
<sTypoAscender value="660"/>
<sTypoDescender value="-340"/>
<sTypoLineGap value="200"/>
<usWinAscent value="988"/>
<usWinAscent value="660"/>
<usWinDescent value="12"/>
<ulCodePageRange1 value="00000000 00000000 00000000 00000001"/>
<ulCodePageRange2 value="00000000 00000000 00000000 00000000"/>
Expand Down
2 changes: 1 addition & 1 deletion tests/makeotf_data/expected_output/bug497/opts-gf-nga.ttx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
<sTypoAscender value="660"/>
<sTypoDescender value="-340"/>
<sTypoLineGap value="200"/>
<usWinAscent value="988"/>
<usWinAscent value="660"/>
<usWinDescent value="12"/>
<ulCodePageRange1 value="00000000 00000000 00000000 00000001"/>
<ulCodePageRange2 value="00000000 00000000 00000000 00000000"/>
Expand Down
2 changes: 1 addition & 1 deletion tests/makeotf_data/expected_output/bug497/opts-gf.ttx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
<sTypoAscender value="660"/>
<sTypoDescender value="-340"/>
<sTypoLineGap value="200"/>
<usWinAscent value="988"/>
<usWinAscent value="660"/>
<usWinDescent value="12"/>
<ulCodePageRange1 value="00000000 00000000 00000000 00000001"/>
<ulCodePageRange2 value="00000000 00000000 00000000 00000000"/>
Expand Down
2 changes: 1 addition & 1 deletion tests/makeotf_data/expected_output/bug497/opts-nga.ttx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
<sTypoAscender value="660"/>
<sTypoDescender value="-340"/>
<sTypoLineGap value="200"/>
<usWinAscent value="988"/>
<usWinAscent value="660"/>
<usWinDescent value="12"/>
<ulCodePageRange1 value="00000000 00000000 00000000 00000001"/>
<ulCodePageRange2 value="00000000 00000000 00000000 00000000"/>
Expand Down
2 changes: 1 addition & 1 deletion tests/makeotf_data/expected_output/bug497/opts-r-ga-gf.ttx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
<sTypoAscender value="660"/>
<sTypoDescender value="-340"/>
<sTypoLineGap value="200"/>
<usWinAscent value="988"/>
<usWinAscent value="660"/>
<usWinDescent value="12"/>
<ulCodePageRange1 value="00000000 00000000 00000000 00000001"/>
<ulCodePageRange2 value="00000000 00000000 00000000 00000000"/>
Expand Down
2 changes: 1 addition & 1 deletion tests/makeotf_data/expected_output/bug497/opts-r-ga.ttx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
<sTypoAscender value="660"/>
<sTypoDescender value="-340"/>
<sTypoLineGap value="200"/>
<usWinAscent value="988"/>
<usWinAscent value="660"/>
<usWinDescent value="12"/>
<ulCodePageRange1 value="00000000 00000000 00000000 00000001"/>
<ulCodePageRange2 value="00000000 00000000 00000000 00000000"/>
Expand Down
2 changes: 1 addition & 1 deletion tests/makeotf_data/expected_output/bug497/opts-r-gf.ttx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
<sTypoAscender value="660"/>
<sTypoDescender value="-340"/>
<sTypoLineGap value="200"/>
<usWinAscent value="988"/>
<usWinAscent value="660"/>
<usWinDescent value="12"/>
<ulCodePageRange1 value="00000000 00000000 00000000 00000001"/>
<ulCodePageRange2 value="00000000 00000000 00000000 00000000"/>
Expand Down
2 changes: 1 addition & 1 deletion tests/makeotf_data/expected_output/bug497/opts-r-nga.ttx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
<sTypoAscender value="660"/>
<sTypoDescender value="-340"/>
<sTypoLineGap value="200"/>
<usWinAscent value="988"/>
<usWinAscent value="660"/>
<usWinDescent value="12"/>
<ulCodePageRange1 value="00000000 00000000 00000000 00000001"/>
<ulCodePageRange2 value="00000000 00000000 00000000 00000000"/>
Expand Down
2 changes: 1 addition & 1 deletion tests/makeotf_data/expected_output/bug497/opts-r.ttx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
<sTypoAscender value="660"/>
<sTypoDescender value="-340"/>
<sTypoLineGap value="200"/>
<usWinAscent value="988"/>
<usWinAscent value="660"/>
<usWinDescent value="12"/>
<ulCodePageRange1 value="00000000 00000000 00000000 00000001"/>
<ulCodePageRange2 value="00000000 00000000 00000000 00000000"/>
Expand Down
2 changes: 1 addition & 1 deletion tests/makeotf_data/expected_output/bug497/opts.ttx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
<sTypoAscender value="660"/>
<sTypoDescender value="-340"/>
<sTypoLineGap value="200"/>
<usWinAscent value="988"/>
<usWinAscent value="660"/>
<usWinDescent value="12"/>
<ulCodePageRange1 value="00000000 00000000 00000000 00000001"/>
<ulCodePageRange2 value="00000000 00000000 00000000 00000000"/>
Expand Down
1 change: 1 addition & 0 deletions tests/makeotf_data/expected_output/bug751.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@ tx: --- tests/makeotf_data/input/bug751.ufo
tx: (ufr) Warning: Encountered empty <string> for fontinfo key copyright. Skipping
tx: (ufr) Warning: Encountered empty <string> for fontinfo key trademark. Skipping
makeotf [Warning] Could not find default features file. Font will be built without any layout features.
makeotfexe [WARNING] <Exercise1-Regular> Negative internal leading: win.ascent + win.descent < unitsPerEm
Built development mode font 'Exercise1-Regular.otf'.
2 changes: 1 addition & 1 deletion tests/makeotf_data/expected_output/font_dev.ttx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
<sTypoAscender value="739"/>
<sTypoDescender value="-261"/>
<sTypoLineGap value="200"/>
<usWinAscent value="987"/>
<usWinAscent value="739"/>
<usWinDescent value="13"/>
<ulCodePageRange1 value="00000000 00000000 00000000 00000001"/>
<ulCodePageRange2 value="00000000 00000000 00000000 00000000"/>
Expand Down
3 changes: 2 additions & 1 deletion tests/makeotf_data/expected_output/font_dev_output.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
makeotf [Warning] Could not find default features file. Font will be built without any layout features.
makeotf [Warning] Could not find FontMenuNameDB file. Font will be built with menu names derived from PostScript name.
makeotfexe [WARNING] FontMenuNameDB file was not specified or not found. [SourceSerifPro-Regular]
Built development mode font 'font.otf'.
makeotfexe [WARNING] <SourceSerifPro-Regular> Negative internal leading: win.ascent + win.descent < unitsPerEm
Built development mode font 'font.otf'.
2 changes: 1 addition & 1 deletion tests/makeotf_data/expected_output/font_rel.ttx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
<sTypoAscender value="739"/>
<sTypoDescender value="-261"/>
<sTypoLineGap value="200"/>
<usWinAscent value="987"/>
<usWinAscent value="739"/>
<usWinDescent value="13"/>
<ulCodePageRange1 value="00000000 00000000 00000000 00000001"/>
<ulCodePageRange2 value="00000000 00000000 00000000 00000000"/>
Expand Down
1 change: 1 addition & 0 deletions tests/makeotf_data/expected_output/font_rel_output.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,5 @@ makeotfexe [WARNING] unhinted <a>
makeotfexe [WARNING] unhinted <b>
makeotfexe [WARNING] FontMenuNameDB file was not specified or not found. [SourceSerifPro-Regular]
makeotfexe [WARNING] Glyph renaming was requested, but the GlyphOrderAndAliasDB file was not specified.
makeotfexe [WARNING] <SourceSerifPro-Regular> Negative internal leading: win.ascent + win.descent < unitsPerEm
Built release mode font 'font.otf' Revision 1.000
2 changes: 1 addition & 1 deletion tests/makeotf_data/expected_output/t1pfa-dev.ttx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
<sTypoAscender value="660"/>
<sTypoDescender value="-340"/>
<sTypoLineGap value="200"/>
<usWinAscent value="988"/>
<usWinAscent value="660"/>
<usWinDescent value="12"/>
<ulCodePageRange1 value="00000000 00000000 00000000 00000001"/>
<ulCodePageRange2 value="00000000 00000000 00000000 00000000"/>
Expand Down
2 changes: 1 addition & 1 deletion tests/makeotf_data/expected_output/t1pfa-rel.ttx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
<sTypoAscender value="660"/>
<sTypoDescender value="-340"/>
<sTypoLineGap value="200"/>
<usWinAscent value="988"/>
<usWinAscent value="660"/>
<usWinDescent value="12"/>
<ulCodePageRange1 value="00000000 00000000 00000000 00000001"/>
<ulCodePageRange2 value="00000000 00000000 00000000 00000000"/>
Expand Down
2 changes: 1 addition & 1 deletion tests/makeotf_data/expected_output/ttf-dev.ttx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@
<sTypoAscender value="660"/>
<sTypoDescender value="-340"/>
<sTypoLineGap value="200"/>
<usWinAscent value="988"/>
<usWinAscent value="660"/>
<usWinDescent value="12"/>
<ulCodePageRange1 value="00000000 00000000 00000000 00000001"/>
<ulCodePageRange2 value="00000000 00000000 00000000 00000000"/>
Expand Down
2 changes: 1 addition & 1 deletion tests/makeotf_data/expected_output/ttf-rel.ttx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@
<sTypoAscender value="660"/>
<sTypoDescender value="-340"/>
<sTypoLineGap value="200"/>
<usWinAscent value="988"/>
<usWinAscent value="660"/>
<usWinDescent value="12"/>
<ulCodePageRange1 value="00000000 00000000 00000000 00000001"/>
<ulCodePageRange2 value="00000000 00000000 00000000 00000000"/>
Expand Down
2 changes: 1 addition & 1 deletion tests/makeotf_data/expected_output/ufo2-dev.ttx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
<sTypoAscender value="660"/>
<sTypoDescender value="-340"/>
<sTypoLineGap value="200"/>
<usWinAscent value="988"/>
<usWinAscent value="660"/>
<usWinDescent value="12"/>
<ulCodePageRange1 value="00000000 00000000 00000000 00000001"/>
<ulCodePageRange2 value="00000000 00000000 00000000 00000000"/>
Expand Down
2 changes: 1 addition & 1 deletion tests/makeotf_data/expected_output/ufo2-rel.ttx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
<sTypoAscender value="660"/>
<sTypoDescender value="-340"/>
<sTypoLineGap value="200"/>
<usWinAscent value="988"/>
<usWinAscent value="660"/>
<usWinDescent value="12"/>
<ulCodePageRange1 value="00000000 00000000 00000000 00000001"/>
<ulCodePageRange2 value="00000000 00000000 00000000 00000000"/>
Expand Down
2 changes: 1 addition & 1 deletion tests/makeotf_data/expected_output/ufo3-dev.ttx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
<sTypoAscender value="660"/>
<sTypoDescender value="-340"/>
<sTypoLineGap value="200"/>
<usWinAscent value="988"/>
<usWinAscent value="660"/>
<usWinDescent value="12"/>
<ulCodePageRange1 value="00000000 00000000 00000000 00000001"/>
<ulCodePageRange2 value="00000000 00000000 00000000 00000000"/>
Expand Down
2 changes: 1 addition & 1 deletion tests/makeotf_data/expected_output/ufo3-rel.ttx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
<sTypoAscender value="660"/>
<sTypoDescender value="-340"/>
<sTypoLineGap value="200"/>
<usWinAscent value="988"/>
<usWinAscent value="660"/>
<usWinDescent value="12"/>
<ulCodePageRange1 value="00000000 00000000 00000000 00000001"/>
<ulCodePageRange2 value="00000000 00000000 00000000 00000000"/>
Expand Down
57 changes: 57 additions & 0 deletions tests/makeotfexe_data/expected_output/bug1227.ttx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
<?xml version="1.0" encoding="UTF-8"?>
<ttFont sfntVersion="OTTO" ttLibVersion="4.18">

<OS_2>
<!-- The fields 'usFirstCharIndex' and 'usLastCharIndex'
will be recalculated by the compiler -->
<version value="3"/>
<xAvgCharWidth value="575"/>
<usWeightClass value="800"/>
<usWidthClass value="3"/>
<fsType value="00000000 00000100"/>
<ySubscriptXSize value="650"/>
<ySubscriptYSize value="600"/>
<ySubscriptXOffset value="0"/>
<ySubscriptYOffset value="75"/>
<ySuperscriptXSize value="650"/>
<ySuperscriptYSize value="600"/>
<ySuperscriptXOffset value="0"/>
<ySuperscriptYOffset value="350"/>
<yStrikeoutSize value="50"/>
<yStrikeoutPosition value="240"/>
<sFamilyClass value="2053"/>
<panose>
<bFamilyType value="2"/>
<bSerifStyle value="15"/>
<bWeight value="0"/>
<bProportion value="0"/>
<bContrast value="2"/>
<bStrokeVariation value="2"/>
<bArmStyle value="8"/>
<bLetterForm value="2"/>
<bMidline value="9"/>
<bXHeight value="4"/>
</panose>
<ulUnicodeRange1 value="00000000 00000000 00000010 00000011"/>
<ulUnicodeRange2 value="00011000 10000000 00000000 00000000"/>
<ulUnicodeRange3 value="00000000 00000000 00000000 00000000"/>
<ulUnicodeRange4 value="00000000 00000000 00000000 00000000"/>
<achVendID value="ADBE"/>
<fsSelection value="00000000 00000000"/>
<usFirstCharIndex value="97"/>
<usLastCharIndex value="98"/>
<sTypoAscender value="800"/>
<sTypoDescender value="-200"/>
<sTypoLineGap value="200"/>
<usWinAscent value="600"/>
<usWinDescent value="321"/>
<ulCodePageRange1 value="00000000 00000010 00000000 00000101"/>
<ulCodePageRange2 value="00000000 00000000 00000000 00000000"/>
<sxHeight value="400"/>
<sCapHeight value="600"/>
<usDefaultChar value="0"/>
<usBreakChar value="32"/>
<usMaxContext value="0"/>
</OS_2>

</ttFont>
2 changes: 1 addition & 1 deletion tests/makeotfexe_data/expected_output/bug438.ttx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
<sTypoAscender value="660"/>
<sTypoDescender value="-340"/>
<sTypoLineGap value="200"/>
<usWinAscent value="988"/>
<usWinAscent value="660"/>
<usWinDescent value="12"/>
<ulCodePageRange1 value="00000000 00000000 00000000 00000001"/>
<ulCodePageRange2 value="00000000 00000000 00000000 00000000"/>
Expand Down
2 changes: 1 addition & 1 deletion tests/makeotfexe_data/expected_output/font_dev.ttx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
<sTypoAscender value="739"/>
<sTypoDescender value="-261"/>
<sTypoLineGap value="200"/>
<usWinAscent value="987"/>
<usWinAscent value="739"/>
<usWinDescent value="13"/>
<ulCodePageRange1 value="00000000 00000000 00000000 00000001"/>
<ulCodePageRange2 value="00000000 00000000 00000000 00000000"/>
Expand Down
1 change: 1 addition & 0 deletions tests/makeotfexe_data/expected_output/font_dev_output.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@ makeotfexe [WARNING] unhinted <.notdef>
makeotfexe [WARNING] unhinted <a>
makeotfexe [WARNING] unhinted <b>
makeotfexe [WARNING] FontMenuNameDB file was not specified or not found. [SourceSerifPro-Regular]
makeotfexe [WARNING] <SourceSerifPro-Regular> Negative internal leading: win.ascent + win.descent < unitsPerEm
2 changes: 1 addition & 1 deletion tests/makeotfexe_data/expected_output/font_rel.ttx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
<sTypoAscender value="739"/>
<sTypoDescender value="-261"/>
<sTypoLineGap value="200"/>
<usWinAscent value="987"/>
<usWinAscent value="739"/>
<usWinDescent value="13"/>
<ulCodePageRange1 value="00000000 00000000 00000000 00000001"/>
<ulCodePageRange2 value="00000000 00000000 00000000 00000000"/>
Expand Down
1 change: 1 addition & 0 deletions tests/makeotfexe_data/expected_output/font_rel_output.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ makeotfexe [WARNING] unhinted <a>
makeotfexe [WARNING] unhinted <b>
makeotfexe [WARNING] FontMenuNameDB file was not specified or not found. [SourceSerifPro-Regular]
makeotfexe [WARNING] Glyph renaming was requested, but the GlyphOrderAndAliasDB file was not specified.
makeotfexe [WARNING] <SourceSerifPro-Regular> Negative internal leading: win.ascent + win.descent < unitsPerEm
2 changes: 1 addition & 1 deletion tests/makeotfexe_data/expected_output/spec/9f-10.ttx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
<sTypoAscender value="0"/>
<sTypoDescender value="-1000"/>
<sTypoLineGap value="200"/>
<usWinAscent value="1000"/>
<usWinAscent value="0"/>
<usWinDescent value="0"/>
<ulCodePageRange1 value="00000000 00000000 00000000 00000001"/>
<ulCodePageRange2 value="00000000 00000000 00000000 00000000"/>
Expand Down
Loading