Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(docs) update README.md #1280

Merged
merged 1 commit into from
Jan 27, 2021
Merged

(docs) update README.md #1280

merged 1 commit into from
Jan 27, 2021

Conversation

vladdoster
Copy link
Contributor

@vladdoster vladdoster commented Jan 18, 2021 •
edited
Loading

Description

  • consistent md formatting
  • remove empty table row
  • add code fences

Checklist:

  • I have followed the Contribution Guidelines
  • I have added test code and data to prove that my code functions correctly
  • I have verified that new and existing tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@vladdoster
(docs) update README.md
a45cad7 
- consistent md formatting
- remove empty table row
- add code fences
kaydeearts
kaydeearts approved these changes Jan 27, 2021
View reviewed changes
Copy link
Collaborator

@kaydeearts kaydeearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kaydeearts kaydeearts merged commit f398999 into adobe-type-tools:master Jan 27, 2021
@cjchapman
Copy link
Contributor

@vladdoster We only noticed this after we merged, but in the future please make your PRs against develop instead of master. We were overdue to sync master to develop anyway, so no worries, Josh just merged your change over as part of #1285.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaydeearts kaydeearts kaydeearts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vladdoster @cjchapman @kaydeearts