Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure format 3 post table doesn't break makeotf #1303

Merged
merged 1 commit into from
Mar 1, 2021
Merged

Conversation

dy
Copy link
Contributor

@dy dy commented Feb 6, 2021

Description

According to the fonttools/fonttools#2178 (comment), it makes sure script doesn't fail on attempt to convert format 3 post table to format 2.

Fixes #1301

@dy dy changed the title Fix #1301 Make sure format 3 post table doesn't break makeotf Feb 6, 2021
Copy link
Collaborator

@kaydeearts kaydeearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good, thanks @dy !

@kaydeearts kaydeearts merged commit c243821 into adobe-type-tools:develop Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

makeotf: AttributeError: 'table__p_o_s_t' object has no attribute 'mapping'
2 participants