[makeotfexe] increase uvName string length limit #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add `MAX_UV_CHAR_NAME_LEN` of 2047 - re-work `gnameScan` to use `MAX_UV_CHAR_NAME_LEN` when `nameType` is uvName, else `MAX_CHAR_NAME_LEN` (previous behavior)
cjchapman
reviewed
Feb 23, 2021
tests/makeotfexe_test.py
Outdated
| with open(stderr_path, 'rb') as f: | ||
| output = f.read() | ||
|
|
||
| assert ((b'(record skipped)(gnameError)') in output) is expected |
There was a problem hiding this comment.
Minor suggestion -- there's a superfluous set of parentheses in this line, and it could be simplified to:
assert (b'(record skipped)(gnameError)' in output) is expectedThere was a problem hiding this comment.
((indeed!))
fixed in 574ed05
remove superfluous parens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increase string length limit for parsing the 3rd column of a GOADB file (aliases/Unicode Value mappings).
Closes #1310
Checklist:
I have made corresponding changes to the documentation