Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cffread.c] data type fix + add, update tests #1344

Merged
merged 2 commits into from
Apr 16, 2021
Merged

[cffread.c] data type fix + add, update tests #1344

merged 2 commits into from
Apr 16, 2021

Conversation

kaydeearts
Copy link
Collaborator

Should fix #1343

punchcutter
punchcutter approved these changes Apr 16, 2021
View reviewed changes
Copy link
Contributor

@punchcutter punchcutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the files we ran into this with and it looks good. Test failing is a separate issue we know about so I think merging this is fine.

@kaydeearts kaydeearts merged commit 3a83d6e into develop Apr 16, 2021
@kaydeearts kaydeearts deleted the kd-cffread-precision-fix branch April 16, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@punchcutter punchcutter punchcutter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[tx] t1read producing bad values for FontBBox and BlueValues
2 participants
@kaydeearts @punchcutter