Add error for fonts surpassing 65000 SID Limit #1347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 2 alerts when merging 1212a02 into 3a83d6e - view on LGTM.com new alerts:
|
kaydeearts
force-pushed
the
kd-rotateFont_segfault_fix
branch
from
80eb04c
to
42ff9e6
Compare
josh-hadley
requested changes
May 5, 2021
kaydeearts
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #1338
In the bug above, the user ran into segfault error after using rotateFont. This was actually due to the source font having too many glyphs for it to be a name-keyed font (should be CID-keyed font instead).
We added an error for this to inform the user, stop the program & avoid segfault.