-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uforead, ufowrite, checkoutlinesufo fixes for reading & writing CID-keyed fonts #1353
Conversation
…ID-keyed (part 1 - more work to come)
…ID-keyed (part 1 - more work to come)
…ntent after realloc)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. There is 1 commented-out line that can be deleted.
@@ -548,7 +715,7 @@ static int writeFontInfo(ufwCtx h, abfTopDict *top) { | |||
fontDict0 = &(top->FDArray.array[h->lastiFD]); | |||
else | |||
fontDict0 = &(top->FDArray.array[0]); | |||
privateDict = &(fontDict0->Private); | |||
// privateDict = &(fontDict0->Private); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can probably delete this line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
This PR adds support for CID-keyed font info previously lost in
tx
&checkoutlinesufo
during reading and writing.