Copy token string when using FeatCtx::tokstr() #1372
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I had thought that
std::string
objects retrieved from the parser tree are valid for the lifetime of the tree but there seems to be some other smart-pointer stuff going on. In most cases there is no difference (because strings are either used in the function where they're retrieved or passed "down") but FeatCtx::tokstr() needs to be changed to store the string.I also changed the "reference token" for feature blocks to the start tag so that the error message makes sense. (That would have been a better choice to begin with anyway.)
Checklist: