[tx] preserve intentional duplicate start points when PFA -> UFO #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaydeearts
force-pushed
the
kd-tx-dup-pt-fix
branch
from
2d93e98
to
83178d8
Compare
josh-hadley
requested changes
Jan 4, 2022
requirements.txt
Outdated
| @@ -2,7 +2,7 @@ | |||
| # we want to have control over the version and guarantee that the XML output | |||
| # of our tools is stable | |||
| # NOTE: hard-pinning (==) here gets relaxed to >= in setup.py | |||
| lxml==4.7.1 | |||
There was a problem hiding this comment.
I think we want to keep the newer lxml now
There was a problem hiding this comment.
Oh I missed that during the rebase, just fixed. Thanks for catching!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate points of type line should not be removed in
txwhen writing a UFO. These points are needed for variable fonts.