Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Python 3.6, add Python 3.10 support #1456

Merged
merged 1 commit into from
Jan 4, 2022
Merged

Drop Python 3.6, add Python 3.10 support #1456

merged 1 commit into from
Jan 4, 2022

Conversation

josh-hadley
Copy link
Collaborator

Description

Updates and improvements to dropping Python 3.6 and add Python 3.10 support:

  • Update test workflow (run on Python 3.7, 3.8, 3.9, and 3.10 only, update cpplint run, colorize pytest log, test uninstall AFDKO)
  • Update coverage workflow (make AFDKO installation & coverage upload separate steps)
  • Update build_wheels workflow (use CIBW Action, only build Python 3.7-3.10 wheels, update tag-matching, remove "Use MSBuild" step)
  • Other miscellaneous updates and improvements to GHA workflows
  • Update README.md to indicate Python 3.7 minimum

Checklist:

  • I have followed the Contribution Guidelines
  • I have added test code and data to prove that my code functions correctly
  • I have verified that new and existing tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@kaydeearts @josh-hadley
Drop Python 3.6, add Python 3.10 support
b2df8c9 
Update coverage workflow
Update build_wheels workflow
Update tag-matching regexp
Remove "Use MSBuild" step
Update workflow trigger rules
Unshallow fetch. Don't install requirements-dev.txt
Make AFDKO installation & coverage upload separate steps
Fail as soon as a cpplint error happens. Print the command.
Color pytest log. Test uninstall the AFDKO.
miguelsousa
miguelsousa approved these changes Jan 2, 2022
View reviewed changes
Copy link
Member

@miguelsousa miguelsousa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

kaydeearts
kaydeearts approved these changes Jan 4, 2022
View reviewed changes
Copy link
Collaborator

@kaydeearts kaydeearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@josh-hadley josh-hadley merged commit 7a7a1c3 into develop Jan 4, 2022
@josh-hadley josh-hadley deleted the drop-py3.6-add-py3.10 branch January 4, 2022 18:28
This was referenced Jan 18, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelsousa miguelsousa miguelsousa approved these changes

@kaydeearts kaydeearts kaydeearts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josh-hadley @miguelsousa @kaydeearts