Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tx] Add safety initialization of pdwCtx structure in pdwNew #1474

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

josh-hadley
Copy link
Collaborator

Description

Updates to pdfwrite.c to avoid an out-of-bounds read error with malformed input files in tx -pdf mode caused by an uninitialized pdwCtx structure. Version numbers for pdfwrite and tx were also updated.

Checklist:

  • I have followed the Contribution Guidelines
  • I have added test code and data to prove that my code functions correctly
  • I have verified that new and existing tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

- Avoids out-of-bounds read error with malformed input files in `tx -pdf` mode.
- Updated tx & pdfwrite version numbers.
Copy link
Collaborator

@kaydeearts kaydeearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@josh-hadley josh-hadley merged commit ec504c3 into develop Feb 24, 2022
@josh-hadley josh-hadley deleted the jh-fix-tx-oob-read branch February 24, 2022 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants