[tx] Don't parse non-FDArray array of dictionaries in fontinfo.plist #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaydeearts
changed the title
josh-hadley
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Masataka reported that he found an error when using
mergefonts. The error is actually intx.Because the UFO was exported from Glyphs3, there was some additional data within fontinfo.plist that was accidentally parsed as FDArray.
For now, I've added a
parsingFDArraybool value that is set totrueonly if thepostscriptFDArraykey was seen when parsing an array of font dictionaries. This is a temporary solution, since the switch to libxml2 parsing will have a more elegant way of dealing with this.We need to decide if it's necessary to start storing this kind of additional data from Glyphs 3 and other apps in the UFO when running it through our tools.