ANTLR v4.9.3 Upgrade #1491
Merged
ANTLR v4.9.3 Upgrade #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaydeearts
requested review from
iterumllc and
josh-hadley
and removed request for
iterumllc
josh-hadley
approved these changes
Mar 18, 2022
iterumllc
approved these changes
Mar 18, 2022
| @@ -43,7 +43,6 @@ jobs: | |||
| output-dir: dist | |||
| env: | |||
| CIBW_BUILD: "cp39-*" | |||
| CIBW_BEFORE_ALL_MACOS: "git config --global url.https://github.com/.insteadOf git://github.com/" | |||
There was a problem hiding this comment.
Should this be removed? (You know better than I -- just checking.)
There was a problem hiding this comment.
Yes this should be fine to remove — I added this as a temporary fix to the utfcpp download problem with the previous ANTLR version. Thanks for checking!We'll really find out if there's problems with this yml file once I merge this and push a new tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.