Copy va_list for second use (and add va_end's to avoid leaking) #1512
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The error-printing code first tries to use a 128 byte buffer for output and then resizes if that fails. This code was mistakenly assuming the va_list wasn't altered as part of the call. This PR makes a copy va_list in case it is needed. It also adds va_end calls that were mistakenly left out of the original PR.
Closes #1504
Checklist: