Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tx] Comment out warning for empty strings & update tests #1536

Merged
merged 2 commits into from
Jul 13, 2022
Merged

[tx] Comment out warning for empty strings & update tests #1536

merged 2 commits into from
Jul 13, 2022

Conversation

kaydeearts
Copy link
Collaborator

@kaydeearts kaydeearts commented Jul 12, 2022 •
edited
Loading

Description

Small fix for #1535 . We'll put these messages back when we add a verbose option.

Checklist:

  • I have followed the Contribution Guidelines
  • I have added test code and data to prove that my code functions correctly
  • I have verified that new and existing tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@kaydeearts kaydeearts requested a review from skef July 12, 2022 23:29
@kaydeearts kaydeearts changed the title [uforead] Comment out warning for empty strings & update tests [tx] Comment out warning for empty strings & update tests Jul 12, 2022
skef
skef previously approved these changes Jul 12, 2022
View reviewed changes
Copy link
Collaborator

@skef skef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaydeearts kaydeearts requested a review from skef July 13, 2022 00:48
@kaydeearts kaydeearts merged commit 9b36d9c into develop Jul 13, 2022
@kaydeearts kaydeearts deleted the kd-fix-warning-msgs branch July 13, 2022 16:10
@kaydeearts kaydeearts mentioned this pull request Jul 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skef skef skef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaydeearts @skef