Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tx] [ufowrite] Fix postscriptUnderline rounding #1537

Merged
merged 5 commits into from
Jul 13, 2022

Conversation

josh-hadley
Copy link
Collaborator

@josh-hadley josh-hadley commented Jul 13, 2022

Description

Update ufowrite (tx) to use floor() instead of round() when writing out postscriptUnderlineThickness and postscriptUnderlinePosition to fix a recently-noted bug which was increasing the value by 1 upon writing. Also added a test to check, as there was not anything in place that tickled this bug.

Fixes #1534

Checklist:

  • I have followed the Contribution Guidelines
  • I have added test code and data to prove that my code functions correctly
  • I have verified that new and existing tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Copy link
Collaborator

@kaydeearts kaydeearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@skef skef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josh-hadley josh-hadley merged commit c0b39bf into develop Jul 13, 2022
@josh-hadley josh-hadley deleted the jh-tx-underline-thickness branch July 13, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tx][ufo] off-by-one error when writing postscriptUnderlineThickness (fontinfo.plist)
3 participants