Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boost number of makeinstancesufo pool processors by one #1561

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

skef
Copy link
Collaborator

@skef skef commented Sep 18, 2022

Description

The makeinstancesufo tests currently fail on single-processor systems due to requesting 0 cores for the multiprocessing pool. This bumps the count by one.

The motivation to leave one processor free is understandable. However, if the "organizing" thread isn't very active when the pool is running it seems fine to rely on the timesharing in the OS and just use all the cores.

Checklist:

  • I have followed the Contribution Guidelines
  • I have added test code and data to prove that my code functions correctly
  • I have verified that new and existing tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@skef skef merged commit f0e7023 into adobe-type-tools:develop Sep 20, 2022
@josh-hadley
Copy link
Collaborator

I approved this and OK'd @skef to bypass the check requirements because of some weirdness with re-triggering the required actions. They ran and passed on the skef/afdko branch so I'm satisfied that everything is 🆗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants