Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the two instances of "rU" #1584

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

colinmford
Copy link
Contributor

Description

Replaces the two instances of "rU" with "r", as python now deals with newlines by default since Python 3.4. Fixes #1583

Checklist:

  • I have followed the Contribution Guidelines
  • [-] I have added test code and data to prove that my code functions correctly
  • I have verified that new and existing tests pass locally with my changes
  • I have performed a self-review of my own code
  • [-] I have commented my code, particularly in hard-to-understand areas
  • [-] I have made corresponding changes to the documentation

Copy link
Collaborator

@josh-hadley josh-hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. The Windows build is failing (and has been for a while) for reasons unrelated to this PR so no concerns about that.

@colinmford
Copy link
Contributor Author

@josh-hadley @frankrolf so we're good for a merge on this?

@frankrolf frankrolf merged commit 184ae00 into adobe-type-tools:develop Dec 16, 2022
@frankrolf
Copy link
Member

I guess so! ¯_(ツ)_/¯

@colinmford colinmford deleted the fix-rU-file-open branch December 22, 2022 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[compareFamily] ValueError: invalid mode: 'rU' when running on Python 3.11
3 participants