Always use blend for stem storage in cffwrite_t2cstr.c #1591
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current version of this file stores stems in a union, with just a float for edge0 and edge1 in one case and a blend structure in the other. CFF2 uses the blend while CFF uses just the float. The blend
.value
happens to coincide with the float.This sort of works but the model breaks down for non-blended stems in CFF2 output. It's better to just use the blend structure for all cases with hasBlend set to false if there's no blend data. That way CFF output can ignore everything but the "default" value and CFF2 output can correctly detect whether it needs to output a blend.
Checklist: